cluster: fail when no private address can be found #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The memberlist library fails when it can't find a private address and no advertise address is given. To return a helpful message to the user, AlertManager mimics the logic from memberlist. However the code had a bug that swallowed the error message and made it difficult for the user to understand how to fix the problem. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
commented
Jun 25, 2018
| if err != nil { | ||
| return nil, errors.Wrap(err, "failed to get private IP") | ||
| } | ||
| if privateIP == "" { | ||
| return nil, errors.Wrap(err, "no private IP found, explicit advertise addr not provided") |
There was a problem hiding this comment.
err being nil, errors.Wrap(err, ...) was also nil.
mxinden
reviewed
Jun 26, 2018
cluster/advertise.go
Outdated
| if err != nil { | ||
| return nil, errors.Wrap(err, "failed to get private IP") | ||
| } | ||
| if privateIP == "" { | ||
| return nil, errors.Wrap(err, "no private IP found, explicit advertise addr not provided") | ||
| return nil, errors.Errorf("no private IP found, explicit advertise addr not provided") |
There was a problem hiding this comment.
No particular reason. I'll update.
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
mxinden
approved these changes
Jul 2, 2018
There was a problem hiding this comment.
Looks good to me. In case there are no final thoughts by @stuartnelson3 I will merge tomorrow.
mxinden
pushed a commit
to mxinden/alertmanager
that referenced
this pull request
Jul 10, 2018
The memberlist library fails when it can't find a private address and no advertise address is given. To return a helpful message to the user, AlertManager mimics the logic from memberlist. However the code had a bug that swallowed the error message and made it difficult for the user to understand how to fix the problem. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Merged
eqyiel
added a commit
to eqyiel/nixpkgs
that referenced
this pull request
Aug 17, 2018
Alertmanager fails to start when the memberlist library cannot find any private IP addresses on the system. This is a safeguard to avoid exposing cluster ports over the internet unintentionally. The workaround is to pass the --cluster.advertise-address argument to AlertManager. See also: prometheus/alertmanager#1437 prometheus/alertmanager#1434
9 tasks
eqyiel
added a commit
to eqyiel/nixpkgs
that referenced
this pull request
Aug 18, 2018
Alertmanager fails to start when the memberlist library cannot find any private IP addresses on the system. This is a safeguard to avoid exposing cluster ports over the internet unintentionally. The workaround is to pass the --cluster.advertise-address argument to AlertManager. See also: prometheus/alertmanager#1437 prometheus/alertmanager#1434
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1434.